Re: [WIP]Vertical Clustered Index (columnar store extension) - take2

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>

To: Tomas Vondra <tomas@vondra.me>

Cc: "Aya Iwata (Fujitsu)" <iwata.aya@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2025-05-26T05:07:25Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Mark ItemPointer arguments as const throughout
- e1ac846f3d28 19 (unreleased) cited
Reorganize GUC structs
- a13833c35f9e 19 (unreleased) cited
Eliminate XLOG_HEAP2_VISIBLE from vacuum phase III
- add323da40a6 19 (unreleased) cited
Update various forward declarations to use typedef
- d4d1fc527bdb 19 (unreleased) cited
Pathify RHS unique-ification for semijoin planning
- 24225ad9aafc 19 (unreleased) cited
Revert "Don't lock partitions pruned by initial pruning"
- 1722d5eb05d8 18.0 cited
For inplace update, send nontransactional invalidations.
- 243e9b40f1b2 18.0 cited
Remove nearly-unused SizeOfIptrData macro.
- 8023b5827fba 10.0 cited

Attachments

v3-0003-VCI-documentation.patch (application/octet-stream) patch v3-0003
v3-0001-Add-postgres-code-fix-needed-for-VCI.patch (application/octet-stream) patch v3-0001
v3-0002-Add-VCI-module.patch (application/octet-stream) patch v3-0002

Hi Tomas.

Thankyou for your extremely valuable post [1]. We are analysing your
review comments and feedback, and will respond later.

Meanwhile, I am attaching updated patches to address the reported
build problems:

> I also tried to build 0002, but unfortunately that fails with:
>
> executor/vci_executor.c: In function ‘vci_setup_executor_hook’:
> executor/vci_executor.c:115:28: error: assignment to
> ‘ExecutorStart_hook_type’ {aka ‘void (*)(QueryDesc *, int)’} from
> incompatible pointer type ‘_Bool (*)(QueryDesc *, int)’
> [-Wincompatible-pointer-types]
>   115 |         ExecutorStart_hook = vci_executor_start_routine;
>       |                            ^
> executor/vci_executor.c: In function ‘vci_executor_start_routine’:
> executor/vci_executor.c:161:28: error: void value not ignored as it
> ought to be
>   161 |                 plan_valid = executor_start_prev(queryDesc, eflags);
>       |                            ^
> executor/vci_executor.c:163:28: error: void value not ignored as it
> ought to be
>   163 |                 plan_valid = standard_ExecutorStart(queryDesc,
> eflags);
>       |                            ^
> make: *** [../../src/Makefile.global:973: executor/vci_executor.o] Error 1
>
> The extension is not added to contrib/Makefile, so "make world" does not
> trigger this failure.


patch v3-0001.
- Only some whitespace issues are addressed

patch v3-0002.
- Fixed the contrib/Makefile to include vci
- Fixed a build error (due to recent commit [2])
- The vci.sgml file is removed (now in patch 0003)

patch v3-0003
- New patch just for the docs.

======
[1] https://www.postgresql.org/message-id/a748aa6b-c7e6-4d02-a590-ab404d590448%40vondra.me
[2] https://github.com/postgres/postgres/commit/1722d5eb05d8e5d2e064cd1798abcae4f296ca9d

Kind Regards,
Peter Smith.
Fujitsu Australia