Horton

Re: pg_createsubscriber --dry-run logging concerns

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Chao Li <li.evan.chao@gmail.com>, Euler Taveira <euler@eulerto.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-10T04:00:03Z
Lists: pgsql-hackers

Attachments

On Tue, Nov 4, 2025 at 10:23 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Nov-04, Peter Smith wrote:
>
> > On Sat, Nov 1, 2025 at 5:02 AM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> > > I'm not opposed to 0001 (to master only), but I think the lines of
> > > dashes are a little excessively noisy.  Are there other opinions on
> > > that?  Note that vacuumlo also has it, with no dashes.
> >
> > It was intentionally "noisy" with dashes to make it impossible to
> > accidentally overlook dry-run mode in the logs. But if that's contrary
> > to the way Postgres does things I am fine if you want to remove the
> > dashes.
>
> Yeah, I don't know if it's The Postgres Way or just accidental, but I'd
> rather stay away from that kind of noise.  Also, from a i18n point of
> view, the lines of dashes (as implemented here) would get in the message
> catalogs, which nobody will appreciate.  Please do make the messages a
> single string rather than two separate strings though, perhaps with an
> embedded newline if more than one line of output is needed.
>

Hi Alvaro,

Here is patch v4-0001 modified as requested:
- dashes are removed
- the message is a single string

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Split dry-run messages into primary and detail

  2. Log a note at program start when running in dry-run mode

  3. Use USECS_PER_SEC from datatype/timestamp.h

  4. Remove WaitPMResult enum in pg_createsubscriber

  5. pg_createsubscriber: reword dry-run log messages