Thread

  1. Re: Proposal: Conflict log history table for Logical Replication

    Peter Smith <smithpb2250@gmail.com> — 2026-05-21T03:59:52Z

    Hi Vignesh.
    
    Thanks for addressing my review comments for the documentation.
    
    Here is one more comment for the v37-0008/0009 (combined) docs patches
    
    ======
    doc/src/sgml/logical-replication.sgml
    
    1.
    +      <row>
    +       <entry><literal>replica_identity</literal></entry>
    +       <entry><type>json</type></entry>
    +       <entry>The JSON representation of the replica identity.</entry>
    +      </row>
    +      <row>
    
    I think patch 0002 modified the CLT column order. This doc's table row
    order should match the order of the CLT columns, so please compare
    again with the schema defined by the latest conflict.c.
    
    ======
    Kind Regards,
    Peter Smith.
    Fujitsu Australia