Re: unpack_sql_state not called?

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-08-31T04:01:02Z
Lists: pgsql-hackers
On Tue, Aug 31, 2021 at 11:31 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Aug 31, 2021 at 09:32:41AM +1000, Peter Smith wrote:
> > Hi. I noticed some code that seems the same as the nearby function
> > unpack_sql_state, and I wondered why it is not just calling it?
>
> This looks like a piece that could have been done in d46bc44, and
> would not matter performance-wise.  No objections from here to do
> this simplification.

Thanks. Do you want me to re-post it as a patch attachment?

------
Kind Regards,
Peter Smith.
Fujitsu Australia



Commits

  1. Refactor one conversion of SQLSTATE to string in elog.c