Horton

Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Shubham Khanna <khannashubham1197@gmail.com>, Euler Taveira <euler@eulerto.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, Nisha Moond <nisha.moond412@gmail.com>, Ajin Cherian <itsajin@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, vignesh C <vignesh21@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>
Date: 2025-04-09T23:52:14Z
Lists: pgsql-hackers

Attachments

On Wed, Apr 9, 2025 at 8:08 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Apr 9, 2025 at 7:48 AM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > I was looking at the recent push for the pg_createsubscription "--all"
> > option [1], because I was absent for several weeks prior.
> >
> > I found some minor non-functional issues as follows:
> >
> > ======
> > doc/src/sgml/ref/pg_createsubscriber.sgml
> > ~
> >
> > 1c.
> > I didn't think the sentence quite belongs here because it isn't
> > describing anything about the --all option. Instead, it is  describing
> > how the source server connection is made.
> >
>
> This sentence describes how we connect when --all option is used. For
> other cases, see the description in the -d option. So, this change is
> not required. If you agree, then you can combine the other two
> patches, and we can proceed with those.
>

OK. Here is a single patch which combines previous patches 0001 and 0003.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Cosmetic fixes for pg_createsubscriber's -all option.

  2. pg_createsubscriber: Add '--all' option.