Horton

Thread

Commits

  1. Doc: Add a description of substream in pg_subscription.

  2. Add support for streaming to built-in logical replication.

  1. pg_subscription - substream column?

    Peter Smith <smithpb2250@gmail.com> — 2021-03-15T22:05:05Z

    I noticed that the PG docs [1] for the catalog pg_subscription doesn't
have any mention of the substream column.

Accidental omission by commit 4648243 [2] from last year?

----
[1] https://www.postgresql.org/docs/devel/catalog-pg-subscription.html
[2] https://github.com/postgres/postgres/commit/464824323e57dc4b397e8b05854d779908b55304

Kind Regards,
Peter Smith.
Fujitsu Australia

  2. Re: pg_subscription - substream column?

    Amit Kapila <amit.kapila16@gmail.com> — 2021-03-16T08:20:46Z

    On Tue, Mar 16, 2021 at 3:35 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> I noticed that the PG docs [1] for the catalog pg_subscription doesn't
> have any mention of the substream column.
>
> Accidental omission by commit 4648243 [2] from last year?
>

Right. I'll fix this unless you or someone else is interested in
providing a patch for this.

-- 
With Regards,
Amit Kapila.

  3. Re: pg_subscription - substream column?

    Peter Smith <smithpb2250@gmail.com> — 2021-03-16T11:57:12Z

    On Tue, Mar 16, 2021 at 7:20 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Mar 16, 2021 at 3:35 AM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > I noticed that the PG docs [1] for the catalog pg_subscription doesn't
> > have any mention of the substream column.
> >
> > Accidental omission by commit 4648243 [2] from last year?
> >
>
> Right. I'll fix this unless you or someone else is interested in
> providing a patch for this.

Sure, I will send a patch for it tomorrow.

----
Kind Regards,
Peter Smith.
Fujitsu Australia.

  4. Re: pg_subscription - substream column?

    Amit Kapila <amit.kapila16@gmail.com> — 2021-03-16T13:45:28Z

    On Tue, Mar 16, 2021 at 5:27 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Tue, Mar 16, 2021 at 7:20 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Tue, Mar 16, 2021 at 3:35 AM Peter Smith <smithpb2250@gmail.com> wrote:
> > >
> > > I noticed that the PG docs [1] for the catalog pg_subscription doesn't
> > > have any mention of the substream column.
> > >
> > > Accidental omission by commit 4648243 [2] from last year?
> > >
> >
> > Right. I'll fix this unless you or someone else is interested in
> > providing a patch for this.
>
> Sure, I will send a patch for it tomorrow.
>

Attached, please find the patch to update the description of substream
in pg_subscription.

-- 
With Regards,
Amit Kapila.

  5. Re: pg_subscription - substream column?

    Peter Smith <smithpb2250@gmail.com> — 2021-03-16T23:26:28Z

    On Wed, Mar 17, 2021 at 12:45 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
>
> Attached, please find the patch to update the description of substream
> in pg_subscription.
>

I applied your patch and regenerated the PG docs to check the result.

LGTM.

----
Kind Regards,
Peter Smith.
Fujitsu Australia

  6. Re: pg_subscription - substream column?

    Amit Kapila <amit.kapila16@gmail.com> — 2021-03-17T03:08:43Z

    On Wed, Mar 17, 2021 at 4:56 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Wed, Mar 17, 2021 at 12:45 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> >
> > Attached, please find the patch to update the description of substream
> > in pg_subscription.
> >
>
> I applied your patch and regenerated the PG docs to check the result.
>
> LGTM.
>

Pushed!

-- 
With Regards,
Amit Kapila.