Re: pg_createsubscriber --dry-run logging concerns

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>
To: n4j@liamg.xyz
Cc: Álvaro Herrera <alvherre@kurilemu.de>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-08T22:42:10Z
Lists: pgsql-hackers
On Sat, Oct 4, 2025 at 3:50 AM Neeraj Shah <n4j@liamg.xyz> wrote:
>
> Hello Peter,
>
> Your suggestion makes sense to me, if it's fine with you then I can submit a patch for this change :).
>

Thanks, but I already had some local patches ready to go.... I was
just waiting for more feedback before posting them.

======
Kind Regards,
Peter Smith.
Fujitsu Australia



Commits

  1. Split dry-run messages into primary and detail

  2. Log a note at program start when running in dry-run mode

  3. Use USECS_PER_SEC from datatype/timestamp.h

  4. Remove WaitPMResult enum in pg_createsubscriber

  5. pg_createsubscriber: reword dry-run log messages