Horton

Thread

Commits

  1. Doc: add see-also references to CREATE PUBLICATION.

  1. CREATE PUBLICATION should "See Also" CREATE SUBSCRIPTION

    Peter Smith <smithpb2250@gmail.com> — 2021-11-15T22:29:26Z

    Hi.

I noticed recently that the CREATE PUBLICATION docs page [1] does not
have any "See Also" reference to the CREATE SUBSCRIPTION docs page
[2].

Perhaps it is deliberate (??) but IMO it just seemed like a
strange/annoying omission that there was no easy way to jump both ways
between those two pages.

OTOH, the reverse is OK - the CREATE SUBSCRIPTION docs page *does*
have a "See Also" reference to CREATE PUBLICATION.

Here is a patch:

--- a/doc/src/sgml/ref/create_publication.sgml
+++ b/doc/src/sgml/ref/create_publication.sgml
@@ -333,6 +333,7 @@ CREATE PUBLICATION sales_publication FOR ALL
TABLES IN SCHEMA marketing, sales;
   <simplelist type="inline">
    <member><xref linkend="sql-alterpublication"/></member>
    <member><xref linkend="sql-droppublication"/></member>
+   <member><xref linkend="sql-createsubscription"/></member>
   </simplelist>
  </refsect1>
 </refentry>

------
[1] https://www.postgresql.org/docs/devel/sql-createpublication.html
[2] https://www.postgresql.org/docs/devel/sql-createsubscription.html

Kind Regards,
Peter Smith.
Fujitsu Australia

  2. Re: CREATE PUBLICATION should "See Also" CREATE SUBSCRIPTION

    Daniel Gustafsson <daniel@yesql.se> — 2021-11-16T13:21:39Z

    > On 15 Nov 2021, at 23:29, Peter Smith <smithpb2250@gmail.com> wrote:

> I noticed recently that the CREATE PUBLICATION docs page [1] does not
> have any "See Also" reference to the CREATE SUBSCRIPTION docs page
> [2].

Nice catch.

>   <simplelist type="inline">
>    <member><xref linkend="sql-alterpublication"/></member>
>    <member><xref linkend="sql-droppublication"/></member>
> +   <member><xref linkend="sql-createsubscription"/></member>

To make it analogous with how CREATE/ALTER for SUBSCRIPTION and PUBLICATION
reference each other, there should IMO be another xref to ALTER SUBSCRIPTION as
well.

Unless there are objections, I'll apply that.

--
Daniel Gustafsson		https://vmware.com/

  3. Re: CREATE PUBLICATION should "See Also" CREATE SUBSCRIPTION

    Masahiko Sawada <sawada.mshk@gmail.com> — 2021-11-17T08:24:55Z

    On Tue, Nov 16, 2021 at 10:21 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 15 Nov 2021, at 23:29, Peter Smith <smithpb2250@gmail.com> wrote:
>
> > I noticed recently that the CREATE PUBLICATION docs page [1] does not
> > have any "See Also" reference to the CREATE SUBSCRIPTION docs page
> > [2].
>
> Nice catch.
>
> >   <simplelist type="inline">
> >    <member><xref linkend="sql-alterpublication"/></member>
> >    <member><xref linkend="sql-droppublication"/></member>
> > +   <member><xref linkend="sql-createsubscription"/></member>
>
> To make it analogous with how CREATE/ALTER for SUBSCRIPTION and PUBLICATION
> reference each other, there should IMO be another xref to ALTER SUBSCRIPTION as
> well.

+1

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

  4. Re: CREATE PUBLICATION should "See Also" CREATE SUBSCRIPTION

    Daniel Gustafsson <daniel@yesql.se> — 2021-11-17T12:45:03Z

    > On 17 Nov 2021, at 09:24, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Tue, Nov 16, 2021 at 10:21 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>> 
>>> On 15 Nov 2021, at 23:29, Peter Smith <smithpb2250@gmail.com> wrote:

>>>  <simplelist type="inline">
>>>   <member><xref linkend="sql-alterpublication"/></member>
>>>   <member><xref linkend="sql-droppublication"/></member>
>>> +   <member><xref linkend="sql-createsubscription"/></member>
>> 
>> To make it analogous with how CREATE/ALTER for SUBSCRIPTION and PUBLICATION
>> reference each other, there should IMO be another xref to ALTER SUBSCRIPTION as
>> well.
> 
> +1

Pushed, thanks for review!

--
Daniel Gustafsson		https://vmware.com/

  5. Re: CREATE PUBLICATION should "See Also" CREATE SUBSCRIPTION

    Peter Smith <smithpb2250@gmail.com> — 2021-11-17T21:24:54Z

    On Wed, Nov 17, 2021 at 11:45 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> Pushed, thanks for review!
>

Thanks!

------
Kind Regards,
Peter Smith.
Fujitsu Australia