Re: [WIP]Vertical Clustered Index (columnar store extension) - take2

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>

To: Japin Li <japinli@hotmail.com>

Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Tomas Vondra <tomas@vondra.me>, "Aya Iwata (Fujitsu)" <iwata.aya@fujitsu.com>, Timur Magomedov <t.magomedov@postgrespro.ru>, shveta malik <shveta.malik@gmail.com>

Date: 2025-07-14T23:03:13Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Mark ItemPointer arguments as const throughout
- e1ac846f3d28 19 (unreleased) cited
Reorganize GUC structs
- a13833c35f9e 19 (unreleased) cited
Eliminate XLOG_HEAP2_VISIBLE from vacuum phase III
- add323da40a6 19 (unreleased) cited
Update various forward declarations to use typedef
- d4d1fc527bdb 19 (unreleased) cited
Pathify RHS unique-ification for semijoin planning
- 24225ad9aafc 19 (unreleased) cited
Revert "Don't lock partitions pruned by initial pruning"
- 1722d5eb05d8 18.0 cited
For inplace update, send nontransactional invalidations.
- 243e9b40f1b2 18.0 cited
Remove nearly-unused SizeOfIptrData macro.
- 8023b5827fba 10.0 cited

On Fri, Jul 11, 2025 at 7:18 PM Japin Li <japinli@hotmail.com> wrote:
>
...
>
> Hi, Peter
>
> 1.
> I'm curious if you encountered the following warning during compilation:
>
> /home/japin/Codes/pg/master/build/../contrib/vci/include/vci_ros.h:745:9: warning: result of comparison of constant 65536 with expression of type 'OffsetNumber' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-c
> ompare]
>   745 |         return vci_MakeUint64FromBlockNumberAndOffset(blockNumber, item->ip_posid);
>       |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home/japin/Codes/pg/master/build/../contrib/vci/include/vci_ros.h:639:19: note: expanded from macro 'vci_MakeUint64FromBlockNumberAndOffset'
>   638 |         (AssertMacro((0 <= (offset)) \
>       |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   639 |                                  && ((offset) < (1U << (BITS_PER_BYTE * sizeof(OffsetNumber))))), \
>       |                                  ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home/japin/Codes/pg/master/build/../src/include/c.h:868:12: note: expanded from macro 'AssertMacro'
>   868 |         ((void) ((condition) || \
>       |                   ^~~~~~~~~
> 1 warning generated.
>
> Since the offset is unsigned, we can infer it's always non-negative. Did I miss
> anything?
>

Yeah, I don't see warnings in my build environment, but OTOH we are
aware there are a number of compiler warnings that are reported by the
cfbot [1].  That  one you cited above is just another one of them.
Addressing all the cfbot compiler warnings in patch 0002 is certainly
on the to-do list.

======
[1] https://cirrus-ci.com/task/5631634596167680

Kind Regards,
Peter Smith.
Fujitsu Australia