Horton

Thread

Commits

  1. Ensure we use the correct spelling of "ensure"

  1. ensure, not insure

    Peter Smith <smithpb2250@gmail.com> — 2023-11-08T06:55:37Z

    Hi,

While looking at GUC messages today I noticed the following:

gettext_noop("The server will use the fsync() system call in several
places to make "
  "sure that updates are physically written to disk. This insures "
  "that a database cluster will recover to a consistent state after "
  "an operating system or hardware crash.")

~

I believe the word should have been "ensures"; not "insures".

In passing I found/fixed a bunch of similar misuses in comments.

======
Kind Regards,
Peter Smith.
Fujitsu Australia.

  2. Re: ensure, not insure

    David Rowley <dgrowleyml@gmail.com> — 2023-11-08T07:31:28Z

    On Wed, 8 Nov 2023 at 19:56, Peter Smith <smithpb2250@gmail.com> wrote:
> gettext_noop("The server will use the fsync() system call in several
> places to make "
>   "sure that updates are physically written to disk. This insures "
>   "that a database cluster will recover to a consistent state after "
>   "an operating system or hardware crash.")
>
> ~
>
> I believe the word should have been "ensures"; not "insures".

I agree. It's surprisingly ancient, having arrived in b700a672f (June 2003).

> In passing I found/fixed a bunch of similar misuses in comments.

Those all look fine to me too.

David

  3. Re: ensure, not insure

    Michael Paquier <michael@paquier.xyz> — 2023-11-09T01:22:09Z

    On Wed, Nov 08, 2023 at 08:31:28PM +1300, David Rowley wrote:
> On Wed, 8 Nov 2023 at 19:56, Peter Smith <smithpb2250@gmail.com> wrote:
>> In passing I found/fixed a bunch of similar misuses in comments.
> 
> Those all look fine to me too.

+1.
--
Michael

  4. Re: ensure, not insure

    David Rowley <dgrowleyml@gmail.com> — 2023-11-09T11:20:59Z

    On Thu, 9 Nov 2023 at 14:22, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Nov 08, 2023 at 08:31:28PM +1300, David Rowley wrote:
> > Those all look fine to me too.
>
> +1.

I've pushed this.  I backpatched due to the typo in the fsync GUC
description.  I'd have only pushed to master if it were just the
comment typos.

I noticed older versions had another instance of "insure" in a code
comment. I opted to leave that one alone since that file is now gone
in more recent versions.

David

  5. Re: ensure, not insure

    Tom Lane <tgl@sss.pgh.pa.us> — 2023-11-09T15:00:12Z

    David Rowley <dgrowleyml@gmail.com> writes:
> I've pushed this.  I backpatched due to the typo in the fsync GUC
> description.  I'd have only pushed to master if it were just the
> comment typos.

FTR, I do not think you should have back-patched.  You created extra
work for the translation team, and the mistake is subtle enough that
it wasn't worth that.  (My dictionary says that "insure and ensure
are often interchangeable, particularly in US English".)

			regards, tom lane