Re: Slow catchup of 2PC (twophase) transactions on replica in LR

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>

To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Vitaly Davydov <v.davydov@postgrespro.ru>, Ajin Cherian <itsajin@gmail.com>

Date: 2024-07-17T04:28:20Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix random failure in 021_twophase.
- 0dcea330babd 18.0 landed
Allow altering of two_phase option of a SUBSCRIPTION.
- 1462aad2e447 18.0 landed
Doc: use true|false rather than on|off for "failover" option
- fa65a022db26 17.0 cited
Support an optional asynchronous commit mode, in which we don't flush WAL
- 4a78cdeb6b59 8.3.0 cited

Attachments

PS_NITPICKS_20240717_2PC_V180003.txt (text/plain)

Hi, here is my review of the v18-0003 patch.

======
sgml/ref/alter_subscription.sgml

nitpick - some minor tweaks to the documentation text. I also added a link
back to the two_phase parameter. Please see the attached diffs file.

======
Kind Regards,
Peter Smith.
Fujitsu Australia