Horton

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Robert Sjöblom <robert.sjoblom@fortnox.se>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-05-17T01:18:26Z
Lists: pgsql-hackers 
+ errhint("Use %s to disassociate the subscription from the slot after
disabling the subscription.",

IMO it looked strange having the word "subscription" 2x in the same sentence.

Maybe you can reword the errhint like:

BEFORE
"Use %s to disassociate the subscription from the slot after disabling
the subscription."

SUGGESTION#1
"Disable the subscription, then use %s to disassociate it from the slot."

SUGGESTION#2
"After disabling the subscription use %s to disassociate it from the slot."

~~~

BTW, it is a bit difficult to follow this thread because the subject
keeps changing.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Fix the errhint message and docs for drop subscription failure.

  2. doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit}

  3. Doc: mention CREATE+ATTACH PARTITION with CREATE TABLE...PARTITION OF.