Horton

Thread

Commits

  1. doc: Add missing description for DROP SUBSCRIPTION IF EXISTS.

  1. DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS"

    Peter Smith <smithpb2250@gmail.com> — 2026-04-01T06:16:00Z

    Hi.

I happened to notice that the "DROP PUBLICATION IF EXISTS" parameter
is documented [1]
------
IF EXISTS
Do not throw an error if the publication does not exist. A notice is
issued in this case.
------

But, the equivalent "DROP SUBSCRIPTION IF EXISTS" parameter
description is missing [2].

~~~

PSA a patch to add similar documentation for DROP SUBSCRIPTION IF EXISTS.

======
[1] https://www.postgresql.org/docs/devel/sql-droppublication.html
[2] https://www.postgresql.org/docs/devel/sql-dropsubscription.html

Kind Regards,
Peter Smith.
Fujitsu Australia

  2. Re: DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS"

    Chao Li <li.evan.chao@gmail.com> — 2026-04-01T06:43:15Z

    
> On Apr 1, 2026, at 14:16, Peter Smith <smithpb2250@gmail.com> wrote:
> 
> Hi.
> 
> I happened to notice that the "DROP PUBLICATION IF EXISTS" parameter
> is documented [1]
> ------
> IF EXISTS
> Do not throw an error if the publication does not exist. A notice is
> issued in this case.
> ------
> 
> But, the equivalent "DROP SUBSCRIPTION IF EXISTS" parameter
> description is missing [2].
> 
> ~~~
> 
> PSA a patch to add similar documentation for DROP SUBSCRIPTION IF EXISTS.
> 
> ======
> [1] https://www.postgresql.org/docs/devel/sql-droppublication.html
> [2] https://www.postgresql.org/docs/devel/sql-dropsubscription.html
> 
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
> <v1-0001-DOCS-Add-missing-description-for-DROP-SUBSCRIPTIO.patch>

Looks good. The patch uses the same phrase for “if exists” as the doc of “drop publication”. And I verified that a notice is issued:

```
evantest=# drop publication if exists aaa;
NOTICE:  publication "aaa" does not exist, skipping
DROP PUBLICATION
evantest=# drop subscription if exists aaa;
NOTICE:  subscription "aaa" does not exist, skipping
DROP SUBSCRIPTION
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

  3. Re: DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS"

    Nathan Bossart <nathandbossart@gmail.com> — 2026-04-01T14:11:35Z

    On Wed, Apr 01, 2026 at 02:43:15PM +0800, Chao Li wrote:
> On Apr 1, 2026, at 14:16, Peter Smith <smithpb2250@gmail.com> wrote:
>> PSA a patch to add similar documentation for DROP SUBSCRIPTION IF EXISTS.
> 
> Looks good. The patch uses the same phrase for “if exists” as the doc of
> “drop publication”. And I verified that a notice is issued:

Thanks.  Will commit/back-patch shortly.

-- 
nathan

  4. Re: DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS"

    Nathan Bossart <nathandbossart@gmail.com> — 2026-04-01T14:54:23Z

    On Wed, Apr 01, 2026 at 09:11:35AM -0500, Nathan Bossart wrote:
> Thanks.  Will commit/back-patch shortly.

Done.

-- 
nathan

  5. Re: DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS"

    Peter Smith <smithpb2250@gmail.com> — 2026-04-01T22:36:12Z

    On Thu, Apr 2, 2026 at 1:54 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Wed, Apr 01, 2026 at 09:11:35AM -0500, Nathan Bossart wrote:
> > Thanks.  Will commit/back-patch shortly.
>
> Done.
>

Thanks for pushing!

======
Kind Regards,
Peter Smith.
Fujitsu Australia