Re: Proposal: Conflict log history table for Logical Replication

Hi Dilip.

Some minor review comments for patch v44-0001.

======
src/backend/catalog/aclchk.c

pg_class_aclmask_ext:

1.
+ /*
+ * For conflict log tables, allow non-superusers to perform
+ * DELETE and TRUNCATE for cleanup and maintenance. While still
+ * restricting INSERT, UPDATE, and USAGE.
+ */

/and maintenance. While still/and maintenance, while still/

======
src/backend/catalog/heap.c

heap_create:

2.
+ if (IsConflictLogTableNamespace(relnamespace))
+ ereport(ERROR,
+ (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
+ errmsg("permission denied to create \"%s.%s\"",
+ get_namespace_name(relnamespace), relname),
+ errdetail("Conflict schema modifications are currently disallowed.")));

This should use the new function to get the schema-qualified relname,
and substitute into "%s" instead of "%s.%s".

======
src/backend/commands/subscriptioncmds.c

CreateSubscription:

3.
+ /*
+ * Establish an internal dependency between conflict log table and
+ * subscription.
+ *
+ * We use DEPENDENCY_INTERNAL to signify that the table's lifecycle is
+ * strictly tied to the subscription, similar to how a TOAST table relates
+ * to its main table or a sequence relates to an identity column.
+ *
+ * This ensures the conflict log table is automatically reaped during a
+ * DROP SUBSCRIPTION via performDeletion().
+ */

/between conflict log table and subscription./between the conflict log
table and the subscription./

======
Kind Regards,
Peter Smith.
Fujitsu Australia