Horton

Re: pg_createsubscriber --dry-run logging concerns

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Chao Li <li.evan.chao@gmail.com>, Euler Taveira <euler@eulerto.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-18T21:35:16Z
Lists: pgsql-hackers 
On Wed, Nov 19, 2025 at 2:39 AM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Nov-12, Peter Smith wrote:
>
> > It is tempting to implement a "--silent" mode, but if I did that, I
> > would then feel obliged to document and test it. I don't want to go
> > further down this rabbit hole for what was originally supposed to be
> > trivial logging.
>
> Yeah, I understand.
>
> > So, I am calling it quits for this 0001 patch.
> >
> > Perhaps it's still of some use to push changes for everything except
> > the pg_resetwal? Or if you prefer to just abandon the whole patch,
> > that is OK too. Thanks for trying.
>
> Got it.  I pushed it for the other programs and marked the CF entry as
> committed -- thanks for the patches and the discussion.

Thanks for pushing!

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Split dry-run messages into primary and detail

  2. Log a note at program start when running in dry-run mode

  3. Use USECS_PER_SEC from datatype/timestamp.h

  4. Remove WaitPMResult enum in pg_createsubscriber

  5. pg_createsubscriber: reword dry-run log messages