Horton

Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL

Peter Smith <smithpb2250@gmail.com>

View thread
From: Peter Smith <smithpb2250@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Sergei Kornilov <sk@zsrv.org>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Önder Kalacı <onderkalaci@gmail.com>
Date: 2023-07-17T03:17:40Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Update the logical replication restriction w.r.t Replica Identity Full.

On Sat, Jul 15, 2023 at 2:10 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Jul 14, 2023 at 2:15 PM Hayato Kuroda (Fujitsu)
> <kuroda.hayato@fujitsu.com> wrote:
> >
> > > > I think it's appropriate to add on the restrictions page. (But mentioning that this
> > > restriction is only for subscriber)
> > > >
> > > > If the list were larger, then the restrictions page could be divided into publisher
> > > and subscriber restrictions. But not for one very specific restriction.
> > > >
> > >
> > > Okay, how about something like: "The UPDATE and DELETE operations
> > > cannot be applied on the subscriber for the published tables that
> > > specify REPLICA IDENTITY FULL when the table has attributes with
> > > datatypes (e.g point or box) that don't have a default operator class
> > > for Btree or Hash. This won't be a problem if the table has a primary
> > > key or replica identity defined for it."?
> >
> > Thanks for discussing and giving suggestions. But it seems that the first
> > sentence is difficult to read for me. How about attached?
> >
>
> The last line seems repetitive to me. So, I have removed it. Apart
> from that patch looks good to me. Sergie, Peter, and others, any
> thoughts?

The v5 patch LGTM.

------
Kind Regards,
Peter Smith.
Fujitsu Australia