Re: pg_createsubscriber: publication-name and subscription-name options do not exist
Peter Smith <smithpb2250@gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
To: Shubham Khanna <khannashubham1197@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
Date: 2024-12-03T04:54:48Z
Lists: pgsql-docs
Hi Shubham, The patch v5-0001 looks mostly OK to me (visual inspection only). But, I did notice one other improvement you could make in passing. 1. - TABLES</literal></link>. If <option>publication-name</option> option is - not specified, it has the following name pattern: + TABLES</literal></link>. If <option>--publication</option> is not + specified, it has the following name pattern: Instead of saying "it has the following name pattern:", IMO it is better to say: "the publication has the following name pattern:". That would make it consistent with the similar sentences which are saying: "... the replication slot has the following name pattern: "... the subscription has the following name pattern:" ====== Kind Regards, Peter Smith. Fujitsu Australia
Commits
-
doc: Clarify some terms for pg_createsubscriber
- 7a35052a2b6e 17.3 landed
- 8817e8d3a4e5 18.0 landed