Horton

Re: Skip collecting decoded changes of already-aborted transactions

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Ajin Cherian <itsajin@gmail.com>, vignesh C <vignesh21@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-01-16T00:43:28Z
Lists: pgsql-hackers 
On Wed, Jan 15, 2025 at 5:49 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Jan 15, 2025 at 3:11 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > It seems we agreed on RBTXN_IS_PREPARED and rbtxn_is_prepared().
> > Adding 'IS' seems to clarify the transaction having this flag *is* a
> > prepared transaction. Both other two constants RBTXN_SENT_PREAPRE and
> > RBTXN_SKIPPED_PREPARE seem not bad to me.
> >
>
> Agreed.
>
> > I find that the proposed
> > names don't increase the consistency much. Thoughts?
> >
>
> I also think so.
>

My thoughts are that any consistency improvement is a step in the
right direction so even "don't increase the consistency much" is still
better than nothing.

But if I am outvoted that's OK. It is not a big deal.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Rename RBTXN_PREPARE to RBTXN_IS_PREPARE for better clarification.

  2. Skip logical decoding of already-aborted transactions.