Horton

Re: Handle infinite recursion in logical replication setup

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>
Date: 2022-07-20T05:08:36Z
Lists: pgsql-hackers 
On Tue, Jul 19, 2022 at 11:34 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Jul 18, 2022 at 9:46 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > I have updated the patch to handle the origin value case
> > insensitively. The attached patch has the changes for the same.
> >
>
> Thanks, the patch looks mostly good to me. I have made a few changes
> in 0001 patch which are as follows: (a) make a comparison of origin
> names in maybe_reread_subscription similar to slot names as in future
> we may support origin names other than 'any' and 'none', (b) made
> comment changes at few places and minor change in one of the error
> message, (c) ran pgindent and slightly changed the commit message.
>
> I am planning to push this day after tomorrow unless there are any
> comments/suggestions.

FYI, the function name in the comment is not same as the function name here:

+/*
+ * IsReservedName
+ * True iff name is either "none" or "any".
+ */
+static bool
+IsReservedOriginName(const char *name)

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Improved CREATE SUBSCRIPTION message for clarity

  2. Fix the test case introduced by commit 8756930190.

  3. Raise a warning if there is a possibility of data from multiple origins.

  4. Add wait_for_subscription_sync for TAP tests.

  5. Bump catversion for commit d8cd0c6c95c0120168df93aae095df4e0682a08a.

  6. Allow users to skip logical replication of data having origin.

  7. Improve two comments related to a boolean DefElem's value

  8. doc: Fix man page whitespace issues