Horton
Menu

Re: Pgoutput not capturing the generated columns

Peter Smith <smithpb2250@gmail.com>

View thread
From: Peter Smith <smithpb2250@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Shubham Khanna <khannashubham1197@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, pgsql-hackers@lists.postgresql.org, euler@eulerto.com
Date: 2024-10-31T02:38:58Z
Lists: pgsql-hackers 
On Thu, Oct 31, 2024 at 1:14 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Thu, 31 Oct 2024 at 04:42, Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > On Thu, Oct 31, 2024 at 3:16 AM vignesh C <vignesh21@gmail.com> wrote:
> > >
> > > On Wed, 30 Oct 2024 at 15:06, Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > >
> > > > On Tue, Oct 29, 2024 at 8:50 PM vignesh C <vignesh21@gmail.com> wrote:
> > > > >
> > > > > Thank you for reporting this issue. The attached v46 patch addresses
> > > > > the problem and includes some adjustments to the comments. Thanks to
> > > > > Amit for sharing the comment changes offline.
> > > > >
> > > >
> > > > Pushed. Kindly rebase and send the remaining patches.
> > >
> > > Thanks for committing this patch, here is a rebased version of the
> > > remaining patches.
> > >
> >
> > Hi,
> >
> > I found that the docs of src/sgml/ddl.sgml [1] are still saying:
> >
> >      <para>
> >       Generated columns are skipped for logical replication and cannot be
> >       specified in a <command>CREATE PUBLICATION</command> column list.
> >      </para>
> >
> > But that is contrary to the new behaviour after the "Replicate
> > generated columns when specified in the column list." commit yesterday
> > [2].
> >
> > It looks like an oversight. I think updating that paragraph should
> > have been included with yesterday's commit.
>
> Thanks for the findings, the attached patch has the changes for the same.
>

LGTM.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Generated column replication.

  2. Rename pubgencols_type to pubgencols in pg_publication.

  3. Doc: Fix column name in pg_publication catalog.

  4. Fix buildfarm failure introduced by commit e65dbc9927.

  5. Change publication's publish_generated_columns option type to enum.

  6. Fix \dRp+ output when describing publications with a lower server version.

  7. Replicate generated columns when 'publish_generated_columns' is set.

  8. Doc: Update the behavior of generated columns in Logical Replication.

  9. Replicate generated columns when specified in the column list.

  10. Doc: Generated columns are skipped for logical replication.