Horton

Re: "out of relcache_callback_list slots" after multiple calls to pg_logical_slot_get_binary_changes

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2023-02-23T02:07:38Z
Lists: pgsql-hackers 
On Thu, Feb 23, 2023 at 11:28 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Feb 22, 2023 at 10:21:51AM +0000, shiy.fnst@fujitsu.com wrote:
> > Thanks for your reply. Using two flags makes sense to me.
> > Attach the updated patch.
>
> Fine by me as far as it goes.  Any thoughts from others?
> --

Should the 'relation_callback_registered' variable name be plural?

Otherwise, LGTM.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Don't repeatedly register cache callbacks in pgoutput plugin.