Horton

Re: Support EXCEPT for TABLES IN SCHEMA publications

Peter Smith <smithpb2250@gmail.com>

View thread
From: Peter Smith <smithpb2250@gmail.com>
To: Nisha Moond <nisha.moond412@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-05-17T01:32:25Z
Lists: pgsql-hackers 
On Fri, May 15, 2026 at 11:32 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
>
...
> > Also, since the assert was not yet modified, how does this even pass
> > the tests if 'alltables' was false?
> >
>
> As you pointed out in the next (7th) comment also, the first two
> patches are not calling GetExcludedPublicationTables(), but are using
> get_publication_relations() directly. Hence, the tests are passing
> even without the assert modification. But patch-0003 does call it, so
> the assert was updated there.
>

Ah, I missed that -- thanks for the explanation.

======
Kind Regards,
Peter Smith.
Fujitsu Australia.