Horton

Re: [HACKERS] logical decoding of two-phase transactions

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Greg Nancarrow <gregn4422@gmail.com>, Ajin Cherian <itsajin@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-06-21T06:37:35Z
Lists: pgsql-hackers

Attachments

On Fri, Jun 18, 2021 at 3:37 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Jun 18, 2021 at 7:43 AM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > On Thu, Jun 17, 2021 at 6:22 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
> > >
> > > For example, in the v86-0001 patch:
> > >
> > > +/*
> > > + * Handle PREPARE message.
> > > + */
> > > +static void
> > > +apply_handle_prepare(StringInfo s)
> > > +{
> > > + LogicalRepPreparedTxnData prepare_data;
> > > + char gid[GIDSIZE];
> > > +
> > > + logicalrep_read_prepare(s, &prepare_data);
> > > +
> > > + Assert(prepare_data.prepare_lsn == remote_final_lsn);
> > >
> > > The above Assert() should be changed to something like:
> > >
> > > +    if (prepare_data.prepare_lsn != remote_final_lsn)
> > > +        ereport(ERROR,
> > > +                (errcode(ERRCODE_PROTOCOL_VIOLATION),
> > > +                 errmsg_internal("incorrect prepare LSN %X/%X in
> > > prepare message (expected %X/%X)",
> > > +                                 LSN_FORMAT_ARGS(prepare_data.prepare_lsn),
> > > +                                 LSN_FORMAT_ARGS(remote_final_lsn))));
> > >
> > > Without being more familiar with this code, it's difficult for me to
> > > judge exactly how many of such cases are in these patches.
> >
> > Thanks for the above example. I will fix this one later, after
> > receiving some more reviews and reports of other Assert cases just
> > like this one.
> >
>
> I think on similar lines below asserts also need to be changed.
>
> 1.
> +static void
> +apply_handle_begin_prepare(StringInfo s)
> +{
> + LogicalRepPreparedTxnData begin_data;
> + char gid[GIDSIZE];
> +
> + /* Tablesync should never receive prepare. */
> + Assert(!am_tablesync_worker());
>
> 2.
> +static void
> +TwoPhaseTransactionGid(Oid subid, TransactionId xid, char *gid, int szgid)
> +{
> ..
> + Assert(TransactionIdIsValid(xid));
>
> 3.
> +static void
> +apply_handle_stream_prepare(StringInfo s)
> +{
> + int nchanges = 0;
> + LogicalRepPreparedTxnData prepare_data;
> + TransactionId xid;
> + char gid[GIDSIZE];
> +
> ..
> ..
> +
> + /* Tablesync should never receive prepare. */
> + Assert(!am_tablesync_worker());
>

Please find attached the latest patch set v88*

Differences from v87* are:

* Rebased to HEAD @ today.

* Replaces several protocol Asserts with ereports
(ERRCODE_PROTOCOL_VIOLATION) in patch 0003 and 0004, as reported by
Greg [1] and Amit [2]. This is in keeping with the commit [3].

----
[1] https://www.postgresql.org/message-id/CAHut%2BPuJKTNRjFre0VBufWMz9BEScC__nT%2BPUhbSaUNW2biPow%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAA4eK1JO3HsOurS988%3DJarej%3DAK6ChE1tLuMNP%3DAZCt6--hVrw%40mail.gmail.com
[3] https://github.com/postgres/postgres/commit/fe6a20ce54cbbb6fcfe9f6675d563af836ae799a

Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Add prepare API support for streaming transactions in logical replication.

  2. Doc: minor improvements for logical replication protocol documentation.

  3. Fix test failure in 021_twophase.pl.

  4. Refactor to make common functions in proto.c and worker.c.

  5. Unify PostgresNode's new() and get_new_node() methods

  6. Fix potential buffer overruns in proto.c.

  7. Add support for prepared transactions to built-in logical replication.

  8. Refactor function parse_subscription_options.

  9. Allow enabling two-phase option via replication protocol.

  10. Don't use Asserts to check for violations of replication protocol.

  11. Improve psql tab completion for options of subcriptions and publications

  12. Rearrange logrep worker's snapshot handling some more.

  13. doc: Update information of new messages for logical replication.

  14. ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION

  15. Allow pgoutput to send logical decoding messages.

  16. Refactor function parse_output_parameters.

  17. Avoid repeated decoding of prepared transactions after a restart.

  18. Fix an oversight in ReorderBufferFinishPrepared.

  19. Allow multiple xacts during table sync in logical replication.

  20. Fix replication of in-progress transactions in tablesync worker.

  21. Fix 'skip-empty-xacts' option in test_decoding for streaming mode.

  22. Use Enum for top level logical replication message types.

  23. Add support for streaming to built-in logical replication.

  24. Fix the logical streaming test.

  25. Implement streaming mode in ReorderBuffer.

  26. Extend the logical decoding output plugin API with stream methods.

  27. Store 2PC GID in commit/abort WAL recs for logical decoding