Horton

Re: IndexAmRoutine aminsertcleanup function can be NULL?

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Japin Li <japinli@hotmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-22T07:36:29Z
Lists: pgsql-hackers 
On Tue, Jul 22, 2025 at 3:36 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Jul 17, 2025 at 01:34:42PM +0800, Japin Li wrote:
> > On Wed, 16 Jul 2025 at 10:08, Peter Smith <smithpb2250@gmail.com> wrote:
> >> What's going on there? Is it just an accidentally missing "/* can be
> >> NULL */" comment?
> >
> > It appears commit c1ec02be1d79 is missing the comment.
>
> Agreed.  That's user-visible, so backpatched down to v17.
>

Thanks to both!

======
Kind Regards,
Peter Smith.
FUjitsu Australia

Commits

  1. Add assertions for all the required index AM callbacks

  2. doc: Inform about aminsertcleanup optional NULLness

  3. Reuse BrinDesc and BrinRevmap in brininsert