Horton

Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Shubham Khanna <khannashubham1197@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-01-05T21:52:07Z
Lists: pgsql-hackers

Attachments

Hi Shubham.

The patch v6-0001 LGTM.

OTOH, if you want to be picky, the docs wording could be slightly
modified to be more consistent with the coded warning message.

CURRENT
Replication failures can occur if required WAL files are prematurely
deleted. To prevent this, the source server must set <xref
linkend="guc-max-slot-wal-keep-size"/> to <literal>-1</literal>,
ensuring WAL files are not automatically removed.

SUGGESTION
Replication failures can occur if required WAL files are missing. To
prevent this, the source server must set <xref
linkend="guc-max-slot-wal-keep-size"/> to <literal>-1</literal> to
ensure that required WAL files are not prematurely removed.

~~~

See the attached NITPICKS diff if you want to make this change.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Raise a WARNING for max_slot_wal_keep_size in pg_createsubscriber.

  2. Improve grammar of options for command arrays in TAP tests