Horton
Menu

Re: Proposal: Conflict log history table for Logical Replication

Peter Smith <smithpb2250@gmail.com>

View thread
From: Peter Smith <smithpb2250@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, shveta malik <shveta.malik@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-15T08:58:50Z
Lists: pgsql-hackers 
Some review comments for v50-0004.

======
src/bin/pg_dump/pg_dump.c

dumpSubscription:

1.
+ * We skip the default value ('log') to match the handling of other
+ * default subscription options.
+ */

There is only one "default", so I think this should say "...other
subscription options", not "...other default subscription options".

======
src/include/catalog/pg_subscription.h

2.
+#define CONFLICT_LOG_RELATION_NAME_FMT "pg_conflict_log_%u"
+

2a.
This format string (and first usage of it) really be in one of the
earlier patches.

~

2b.
Add a comment to explain that the %u is the subscription oid.

~

2c.
Is this the correct header file for this? IMO it is CLT specific, so
belongs in conflict.h.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Allow logical replication conflicts to be logged to a table.

  2. Avoid orphaned objects dependencies