Horton

Re: Add support for specifying tables in pg_createsubscriber.

Peter Smith <smithpb2250@gmail.com>

View thread
From: Peter Smith <smithpb2250@gmail.com>
To: Shubham Khanna <khannashubham1197@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, vignesh C <vignesh21@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-11T22:55:07Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Support existing publications in pg_createsubscriber.

Hi Shubham,

Here are some v15 review comments.

======
IIUC the test cases #3 and #4 are supposed to reuse an existing publication.

There is logging in the code:
+ /* Reuse existing publication on publisher. */
+ pg_log_info("use existing publication \"%s\" in database \"%s\"",
+ dbinfo[i].pubname, dbinfo[i].dbname);

But I do not see those logs appearing anywhere in the test results.

I think this is caused by a simple mismatch in your test script
between the pub names in the db versus the pub names you are using in
those test commands.

======
Kind Regards,
Peter Smith.
Fujitsu Australia.