Re: Pgoutput not capturing the generated columns

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>

To: vignesh C <vignesh21@gmail.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Shubham Khanna <khannashubham1197@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, pgsql-hackers@lists.postgresql.org, euler@eulerto.com

Date: 2024-11-05T07:02:24Z

Lists: pgsql-hackers

Hi Vignesh,

Here are my review comments for patch v48-0001.

======
src/backend/catalog/pg_publication.c

has_column_list_defined:

1.
+ if (HeapTupleIsValid(cftuple))
+ {
+ bool isnull = true;
+
+ /* Lookup the column list attribute. */
+ (void) SysCacheGetAttr(PUBLICATIONRELMAP, cftuple,
+    Anum_pg_publication_rel_prattrs,
+    &isnull);

AFAIK it is not necessary to assign a default value to 'isnull' here.
e.g. most of the other 100s of calls to SysCacheGetAttr elsewhere in
PostgreSQL source don't bother to do this.

//////////

I also checked the docs patch v48-0002. That now looks good to me.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Doc: Generated column replication.
- 6252b1eaf82b 18.0 landed
Rename pubgencols_type to pubgencols in pg_publication.
- 75eb9766ec20 18.0 landed
Doc: Fix column name in pg_publication catalog.
- 117f9f328e0f 18.0 landed
Fix buildfarm failure introduced by commit e65dbc9927.
- b35434b134b1 18.0 landed
Change publication's publish_generated_columns option type to enum.
- e65dbc9927fb 18.0 landed
Fix \dRp+ output when describing publications with a lower server version.
- 991974bb4888 18.0 landed
Replicate generated columns when 'publish_generated_columns' is set.
- 7054186c4ebe 18.0 landed
Doc: Update the behavior of generated columns in Logical Replication.
- 5b0c46ea0932 18.0 landed
Replicate generated columns when specified in the column list.
- 745217a051a9 18.0 landed
Doc: Generated columns are skipped for logical replication.
- 7a089f6e6a14 17.0 cited