Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis
Peter Smith <smithpb2250@gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-26T22:24:51Z
Lists: pgsql-hackers
Attachments
- v8-0001-PG18.-Fix-synopsis.patch (application/octet-stream) patch v8-0001
- v8-0001-PG16.-Fix-synopsis.patch (application/octet-stream) patch v8-0001
- v8-0001-PG17.-Fix-synopsis.patch (application/octet-stream) patch v8-0001
- v8-0001-PG15.-Fix-synopsis.patch (application/octet-stream) patch v8-0001
- v8-0001-PG19devel.-Fix-synopsis.patch (application/octet-stream) patch v8-0001
On Tue, Nov 25, 2025 at 10:47 PM Chao Li <li.evan.chao@gmail.com> wrote: > > > > > On Nov 25, 2025, at 18:42, Fujii Masao <masao.fujii@gmail.com> wrote: > > > > On Fri, Nov 21, 2025 at 3:27 PM Chao Li <li.evan.chao@gmail.com> wrote: > >> > >> > >> > >>> On Nov 21, 2025, at 05:08, Peter Smith <smithpb2250@gmail.com> wrote: > >>> > >>> I've reverted the ALTER 'publication_drop_object' part to be the same > >>> as master (i.e. removed the v6 'table' replacement) after Fujii-San > >>> showed [1] that the original synopsis style is present on some other > >>> documentation pages. > >>> > >>> PSS new patch v7. > > > > Thanks for updating the patch! LGTM. > > > > One question: do we want to backpatch this? If so, to which versions? > > If we decide to backpatch, it would be helpful if you could provide versions > > of the patch that apply cleanly to those older branches. > > > > I just checked the docs version by version, looks like the back-port can go down to 15. > Here are the back patches as requested. I hope they are OK. ~~~ v8-PG19devel - same as v7. v8-PG18 - same as above, except the CREATE 'publication_all_object' is not needed because FOR ALL SEQUENCES did not exist v8-PG17 - same as above v8-PG16 - same as above v8-PG15 - same as above ====== Kind Regards, Peter Smith. Fujitsu Australia
Commits
-
doc: Fix misleading synopsis for CREATE/ALTER PUBLICATION.
- f9f928304bb7 15.16 landed
- fc6e1a0f2bad 16.12 landed
- d7977668eec6 17.8 landed
- 9ad15f404a70 18.2 landed
- 246ec4a51c16 19 (unreleased) landed