DOCS: pg_createsubscriber wrong link?
Peter Smith <smithpb2250@gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-12-13T05:27:38Z
Lists: pgsql-hackers
Attachments
- v1-0001-DOCS-Fix-wrong-linkend-on-pg_createsubscriber-pag.patch (application/octet-stream) patch v1-0001
Hi,
While reviewing the pg_createsubscriber [1] docs I found a potentially
wrong linkend.
This sentence:
"For smaller databases, initial data synchronization is recommended."
links to [2] ("29.4.5. Initial Data Synchronization").
This seems to have been deliberately changed (commit [3])
FROM: <link linkend="logical-replication">initial data synchronization</link>
TO: <link linkend="logical-replication-row-filter-initial-data-sync">initial
data synchronization</link>
Although the title "Initial Data Synchronization" seems at face value
to be relevant, this particular link target is a sub-section of "Row
Filters", so I don't see why this would be the intended link from the
pg_createsubscriber. AFAICT, the original discussion and commit
message does not explain.
~~
Here is a new patch giving an alternate link which IMO might be more
appropriate.
Thoughts?
======
[1] https://www.postgresql.org/docs/current/app-pgcreatesubscriber.html
[2] https://www.postgresql.org/docs/current/logical-replication-row-filter.html#LOGICAL-REPLICATION-ROW-FILTER-INITIAL-DATA-SYNC
[3] https://github.com/postgres/postgres/commit/84db9a0eb10dd1dbee6db509c0e427fa237177dc
Kind Regards,
Peter Smith.
Fujitsu Australia
Commits
-
Doc: Fix the wrong link on pg_createsubscriber page.
- 2364f61488ec 18.0 landed
- 88baa2791418 17.3 landed
-
Doc: Update link to the mentioned subsection
- 84db9a0eb10d 17.0 cited