Re: [16+] subscription can end up in inconsistent state

On Thu, Oct 5, 2023 at 9:50 PM vignesh C <vignesh21@gmail.com> wrote:
>

> > 3. Connection string option 'passfile'?
> >
> > IIUC the subscription "password_required" option means that the
> > password must be in the connection string. I'm not sure how the other
> > connection string "passfile" option [2] fits into this rule. The
> > current patch looks like it would reject the passfile option (because
> > IIUC libpqrcv_check_conninfo only looks for "password") -- is it
> > deliberate? And, should it be documented/commented somewhere?
> >
> > ======
> > src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
>
> I felt we should not allow password from the passfile for
> non-superusers, if password_required is true, the password can be
> specified only through the password option of the connection string.
> The same has been documented.
>

Assuming that everybody is happy with the above decision to only allow
the 'password' parameter, then your latest v5-0001 patch looked good
to me.

======
Kind Regards,
Peter Smith.
Fujitsu Australia.