Horton

Re: Handle infinite recursion in logical replication setup

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-06-03T05:26:29Z
Lists: pgsql-hackers 
Please find below my review comments for patch v17-0001:

======

1. Commit message
Add a missing test to verify only-local option in test_decoding plugin.

"option" -> "parameter"

======

2. contrib/test_decoding/sql/replorigin.sql

2a.
+-- Verify that remote origin data is not returned with only-local option

SUGGESTION
-- Verify the behaviour of the only-local parameter

2b.
+-- Remote origin data returned when only-local option is not set

"option" -> "parameter"

2c.
+-- Remote origin data not returned when only-local option is set

"option" -> "parameter"

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Improved CREATE SUBSCRIPTION message for clarity

  2. Fix the test case introduced by commit 8756930190.

  3. Raise a warning if there is a possibility of data from multiple origins.

  4. Add wait_for_subscription_sync for TAP tests.

  5. Bump catversion for commit d8cd0c6c95c0120168df93aae095df4e0682a08a.

  6. Allow users to skip logical replication of data having origin.

  7. Improve two comments related to a boolean DefElem's value

  8. doc: Fix man page whitespace issues