Re: row filtering for logical replication
Peter Smith <smithpb2250@gmail.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Release cache tuple when no longer needed
- ed0fbc8e5ac9 15.0 landed
-
Add some additional tests for row filters in logical replication.
- ceb57afd3ce1 15.0 landed
-
Fix one of the tests introduced in commit 52e4f0cd47.
- cfb4e209ec15 15.0 landed
-
Allow specifying row filters for logical replication of tables.
- 52e4f0cd472d 15.0 landed
-
Move scanint8() to numutils.c
- cfc7191dfea3 15.0 cited
-
Replace Test::More plans with done_testing
- 549ec201d613 15.0 cited
-
Reduce relcache access in WAL sender streaming logical changes
- 6ce16088bfed 15.0 cited
-
Small cleanups related to PUBLICATION framework code
- c9105dd3660f 15.0 cited
-
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 cited
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 cited
-
Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.
- 1882d6cca161 15.0 cited
-
Add PublicationTable and PublicationRelInfo structs
- 0c6828fa987b 15.0 cited
-
Remove unused argument "txn" in maybe_send_schema().
- 93d573d86571 15.0 cited
-
Add prepare API support for streaming transactions in logical replication.
- 63cf61cdeb7b 15.0 cited
-
Unify PostgresNode's new() and get_new_node() methods
- 201a76183e20 15.0 cited
-
Use l*_node() family of functions where appropriate
- 2b00db4fb0c7 15.0 cited
-
Add support for prepared transactions to built-in logical replication.
- a8fd13cab0ba 15.0 cited
-
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.
- ef9480509622 11.13 cited
-
Rename a parse node to be more general
- 91d1f2d30210 14.0 landed
-
Remove unused column atttypmod from initial tablesync query
- 4ad31bb2ef25 14.0 landed
-
SEARCH and CYCLE clauses
- 3696a600e229 14.0 cited
On Sun, Nov 28, 2021 at 6:17 PM Peter Smith <smithpb2250@gmail.com> wrote: > > On Fri, Nov 26, 2021 at 1:16 PM houzj.fnst@fujitsu.com > <houzj.fnst@fujitsu.com> wrote: > > > ... > > Based on this direction, I tried to write a top up POC patch(0005) which I'd like to share. > > > > The top up patch mainly did the following things. > > > > * Move the row filter columns invalidation to CheckCmdReplicaIdentity, so that > > the invalidation is executed only when actual UPDATE or DELETE executed on the > > published relation. It's consistent with the existing check about replica > > identity. > > > > * Cache the results of the validation for row filter columns in relcache to > > reduce the cost of the validation. It's safe because every operation that > > change the row filter and replica identity will invalidate the relcache. > > > > Also attach the v42 patch set to keep cfbot happy. > Now I looked at the patch 0005 test cases. Since this patch does the RI validation at UPDATE/DELETE execution instead of at the time of CREATE PUBLICATION it means that currently, the CREATE PUBLICATION is always going to succeed. So IIUC I think it is accidentally missing a DROP PUBLICATION for one of the tests because the "ERROR: publication "testpub6" already exists" should not be happening. Below is a fragment from the regression test publication.out I am referring to: CREATE PUBLICATION testpub6 FOR TABLE rf_tbl_abcd_pk WHERE (a > 99); -- fail - "a" is in PK but it is not part of REPLICA IDENTITY NOTHING UPDATE rf_tbl_abcd_pk set a = 1; ERROR: cannot update table "rf_tbl_abcd_pk" DETAIL: Not all row filter columns are not part of the REPLICA IDENTITY CREATE PUBLICATION testpub6 FOR TABLE rf_tbl_abcd_pk WHERE (c > 99); ERROR: publication "testpub6" already exists ------ Kind Regards, Peter Smith. Fujitsu Australia