Re: Introduce XID age and inactive timeout based replication slot invalidation
Peter Smith <smithpb2250@gmail.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Add a test for commit ac0e33136a using the injection point.
- 8a695d7998be 18.0 landed
-
Invalidate inactive replication slots.
- ac0e33136abc 18.0 landed
-
Fix incorrect slot type in BuildTupleHashTableExt
- d96d1d5152f3 18.0 cited
-
Allow synced slots to have their inactive_since.
- 6f132ed693b6 17.0 landed
-
Change last_inactive_time to inactive_since in pg_replication_slots.
- 6d49c8d4b4f4 17.0 landed
-
Track last_inactive_time in pg_replication_slots.
- a11f330b5584 17.0 landed
-
Track invalidation_reason in pg_replication_slots.
- 6ae701b4378d 17.0 landed
-
Add option force_initdb to PostgreSQL::Test::Cluster:init()
- ff9e1e764fcc 17.0 cited
-
Add a failover option to subscriptions.
- 776621a5e479 17.0 cited
-
Allow setting failover property in the replication command.
- 73292404370c 17.0 cited
-
Allow to enable failover property for replication slots via SQL API.
- c393308b69d2 17.0 cited
-
Track conflict_reason in pg_replication_slots.
- 007693f2a3ac 17.0 cited
-
Log messages for replication slot acquisition and release.
- 7c3fb505b14e 17.0 cited
-
Remove vacuum_defer_cleanup_age
- 1118cd37eb61 16.0 cited
-
Fix corruption due to vacuum_defer_cleanup_age underflowing 64bit xids
- be504a3e974d 16.0 cited
-
meson: Add initial version of meson based build system
- e6927270cd18 16.0 cited
Hi Nisha, Here are my review comments for the v53* patch set ////////// Patch v53-0001. ====== src/backend/replication/slot.c 1. + if (error_if_invalid && + s->data.invalidated != RS_INVAL_NONE) Looks like some unnecessary wrapping here. I think this condition can be on one line. ////////// Patch v53-0002. ====== GENERAL - How about using the term "idle"? 1. I got to wondering why this new GUC was called "replication_slot_inactive_timeout", with invalidation_reason = "inactive_timeout". When I look at similar GUCs I don't see words like "inactivity" or "inactive" anywhere; Instead, they are using the term "idle" to refer to when something is inactive: e.g. #idle_in_transaction_session_timeout = 0 # in milliseconds, 0 is disabled #idle_session_timeout = 0 # in milliseconds, 0 is disabled I know the "inactive" term is used a bit in the slot code but that is (mostly) not exposed to the user. Therefore, I am beginning to feel it would be better (e.g. more consistent) to use "idle" for the user-facing stuff. e.g. New Slot GUC = "idle_replication_slot_timeout" Slot invalidation_reason = "idle_timeout" Of course, changing this will cascade to impact quite a lot of other things in the patch -- comments, error messages, some function names etc. ====== doc/src/sgml/logical-replication.sgml 2. + <para> + Logical replication slot is also affected by + <link linkend="guc-replication-slot-inactive-timeout"><varname>replication_slot_inactive_timeout</varname></link>. + </para> + /Logical replication slot is also affected by/Logical replication slots are also affected by/ ====== Kind Regards, Peter Smith. Fujitsu Australia