Re: [HACKERS] logical decoding of two-phase transactions

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-03-08T01:46:43Z
Lists: pgsql-hackers

Attachments

Please find attached the latest patch set v52*

Differences from v51* are:

* Rebased to HEAD @ today

* No code changes; only a merging of the v51 patches as requested [ak].

v52-0001 <== v51-0001 "track replication origin"
v52-0002 <== v51-0002 "add support for apply at prepare time" +
v51-0003 "add two phase option for create slot" + v51-0006 "fix apply
worker empty prepare"
v52-0003 <== v51-0004 "2pc tests"
v52-0004 <== v51-0005 "Subscription option"
v52-0005 <== v51-0007 "empty prepare extra logging"

-----
[ak] https://www.postgresql.org/message-id/CAA4eK1%2BdO07RrQwfHAK5jDP9qiXik4-MVzy%2BcoEG09shWTJFGg%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia

On Sun, Mar 7, 2021 at 1:04 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Please find attached the latest patch set v51*
>
> Differences from v50* are:
>
> * Rebased to HEAD @ today
>
> * Addresses following feedback comments:
>
> From Osunmi-san @ 2021-03-06 [ot]
> - (27) Fixed. Patch 0003. Remove weird chars from the error message.
>
> From Amit @ 2021-03-06 [ak]
> - (29) Removed patch 0007 "tablesync early exit" from this patch set.
> I started a new thread [early-exit] for this.
> - (30) Removed patch 0001 "refactor spool file logic" from this patch set.
> - (31) Fixed. Patch 0005 removed TODO from test code.
> - (32) Fixed. Patch 0006 comment typo.
> - (33) Fixed. Patch 0008 commit message lines were too long
> - (34) Fixed. Patch 0008 comment reworded avoiding words like
> "problem" and "fix"
>
> -----
> [ot] https://www.postgresql.org/message-id/OSBPR01MB4888636EB9421C930FB39A19ED959%40OSBPR01MB4888.jpnprd01.prod.outlook.com
> [ak] https://www.postgresql.org/message-id/CAA4eK1Jxu-3qxtkfA_dKoquQgGZVcB%2Bk9_-yT5%3D9GDEW84TF%2BA%40mail.gmail.com
> [early-exit] https://www.postgresql.org/message-id/CAHut%2BPt39PbQs0SxT9RMM89aYiZoQ0Kw46YZSkKZwK8z5HOr3g%40mail.gmail.com
>
> Kind Regards,
> Peter Smith.
> Fujitsu Australia

Commits

  1. Add prepare API support for streaming transactions in logical replication.

  2. Doc: minor improvements for logical replication protocol documentation.

  3. Fix test failure in 021_twophase.pl.

  4. Refactor to make common functions in proto.c and worker.c.

  5. Unify PostgresNode's new() and get_new_node() methods

  6. Fix potential buffer overruns in proto.c.

  7. Add support for prepared transactions to built-in logical replication.

  8. Refactor function parse_subscription_options.

  9. Allow enabling two-phase option via replication protocol.

  10. Don't use Asserts to check for violations of replication protocol.

  11. Improve psql tab completion for options of subcriptions and publications

  12. Rearrange logrep worker's snapshot handling some more.

  13. doc: Update information of new messages for logical replication.

  14. ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION

  15. Allow pgoutput to send logical decoding messages.

  16. Refactor function parse_output_parameters.

  17. Avoid repeated decoding of prepared transactions after a restart.

  18. Fix an oversight in ReorderBufferFinishPrepared.

  19. Allow multiple xacts during table sync in logical replication.

  20. Fix replication of in-progress transactions in tablesync worker.

  21. Fix 'skip-empty-xacts' option in test_decoding for streaming mode.

  22. Use Enum for top level logical replication message types.

  23. Add support for streaming to built-in logical replication.

  24. Fix the logical streaming test.

  25. Implement streaming mode in ReorderBuffer.

  26. Extend the logical decoding output plugin API with stream methods.

  27. Store 2PC GID in commit/abort WAL recs for logical decoding