Re: create subscription - improved warning message

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-10-14T02:52:11Z
Lists: pgsql-hackers

Attachments

On Thu, Oct 13, 2022 at 9:07 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Thu, Oct 13, 2022 at 2:01 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > > On 2022-Oct-12, Amit Kapila wrote:
> > >> Okay, then I think we can commit the last error message patch of Peter
> > >> [1] as we have an agreement on the same, and then work on this as a
> > >> separate patch. What do you think?
> >
> > > No objection.
> >
> > Yeah, the v3-0001 patch is fine.  I agree that the docs change needs
> > more work.
>
> Thanks to everybody for the feedback/suggestions. I will work on
> improving the documentation for this and post something in a day or
> so.


PSA a patch for adding examples of how to activate a subscription that
was originally created in a disconnected mode.

The new docs are added as part of the "Logical Replication -
Subscription" section 31.2.

The CREATE SUBSCRIPTION reference page was also updated to include
links to the new docs.

Feedback welcome.

------
Kind Regards,
Peter Smith.
Fujitsu Australia.

Commits

  1. Doc: Update information about manually creating slots.

  2. Improve the WARNING message for CREATE SUBSCRIPTION.