Horton

Re: Single transaction in the tablesync worker?

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-09T08:33:22Z
Lists: pgsql-hackers 
When looking at the DropSubscription code I noticed that there is a
small difference between the HEAD code and the V29 code when slot_name
= NONE.

HEAD does
------
    if (!slotname)
    {
        table_close(rel, NoLock);
        return;
    }
------

V29 does
------
        if (!slotname)
        {
            /* be tidy */
            list_free(rstates);
            return;
        }
------

Isn't the V29 code missing doing a table_close(rel, NoLock) there?

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Fix relcache reference leak introduced by ce0fdbfe97.

  2. Fix Subscription test added by commit ce0fdbfe97.

  3. Allow multiple xacts during table sync in logical replication.

  4. Logical replication support for initial data copy