Re: Single transaction in the tablesync worker?
Peter Smith <smithpb2250@gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-01-25T11:41:46Z
Lists: pgsql-hackers
On Mon, Jan 25, 2021 at 2:54 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Mon, Jan 25, 2021 at 8:23 AM Peter Smith <smithpb2250@gmail.com> wrote: > > > > On Sat, Jan 23, 2021 at 11:26 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > > > 2. > > > @@ -98,11 +102,16 @@ > > > #include "miscadmin.h" > > > #include "parser/parse_relation.h" > > > #include "pgstat.h" > > > +#include "postmaster/interrupt.h" > > > #include "replication/logicallauncher.h" > > > #include "replication/logicalrelation.h" > > > +#include "replication/logicalworker.h" > > > #include "replication/walreceiver.h" > > > #include "replication/worker_internal.h" > > > +#include "replication/slot.h" > > > > > > I don't think the above includes are required. They seem to the > > > remnant of the previous approach. > > > > > > > OK. Fixed in the latest patch [v19]. > > > > You seem to forgot removing #include "replication/slot.h". Check, if > it is not required then remove that as well. > Fixed in the latest patch [v20]. ---- [v20] https://www.postgresql.org/message-id/CAHut%2BPuNwSujoL_dwa%3DTtozJ_vF%3DCnJxjgQTCmNBkazd8J1m-A%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
Commits
-
Fix relcache reference leak introduced by ce0fdbfe97.
- 8a4f9522d0c7 14.0 landed
-
Fix Subscription test added by commit ce0fdbfe97.
- c8b21b037814 14.0 landed
-
Allow multiple xacts during table sync in logical replication.
- ce0fdbfe9722 14.0 landed
-
Logical replication support for initial data copy
- 7c4f52409a8c 10.0 cited