Re: Redundant/mis-use of _(x) gettext macro?
Peter Smith <smithpb2250@gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-11T22:57:33Z
Lists: pgsql-hackers
On Fri, Jun 12, 2026 at 2:44 AM Álvaro Herrera <alvherre@kurilemu.de> wrote: > > On 2026-Apr-24, Peter Smith wrote: > > > OK. Including the comma within a larger translated string seems like a > > better idea. > [...] > > Also, why did you choose to implement `last` versus `first` logic? > > e.g. How about this? > > In the end I decided to go with the flow and changed to use "first" > logic rather than "last". I also figured that we should change the > other two places you pointed out at the start of the thread to use the > same coding style. Since this is mostly cosmetic, I don't feel > compelled to back-patch it, and pushed only to master. > Thanks for pushing! > Another place I noticed while looking this over is psql's > describeOneTableDetails(), per the attached patch. It's essentially > more of the same, but arguably different enough that I judged it > warranted posting before pushing. > This additional patch LGTM. ====== Kind Regards, Peter Smith. Fujitsu Australia
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix translatable string construction in psql
- 5459223edb1d 19 (unreleased) landed
-
Fix translatable string construction
- 3692a622d3fd 19 (unreleased) landed