Re: [PoC] pg_upgrade: allow to upgrade publisher node

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>

To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

Cc: Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Amit Kapila <amit.kapila16@gmail.com>

Date: 2023-04-12T05:25:31Z

Lists: pgsql-hackers

FYI, here are some minor review comments for v4-0001

======
src/bin/pg_dump/pg_backup.h

1.
+ int logical_slot_only;

The field should be plural - "logical_slots_only"

======
src/bin/pg_dump/pg_dump.c

2.
+ appendPQExpBufferStr(query,
+ "SELECT r.slot_name, r.plugin, r.two_phase "
+ "FROM pg_replication_slots r "
+ "WHERE r.database = current_database() AND temporary = false "
+ "AND wal_status IN ('reserved', 'extended');");

The alias 'r' may not be needed at all here, but since you already
have it IMO it looks a bit strange that you used it for only some of
the columns but not others.

~~~

3.
+
+ /* FIXME: force dumping */
+ slotinfo[i].dobj.dump = DUMP_COMPONENT_ALL;

Why the "FIXME" here? Are you intending to replace this code with
something else?

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

Fix issues in binary_upgrade_logical_slot_has_caught_up().
- 0bf62460bb9e 17.0 landed
Fix a random failure in 003_logical_slots.pl.
- 63c5df126abb 17.0 landed
Fix a test in 003_logical_slots.
- 3e36e48d8efe 17.0 landed
Fix uninitialized slot array access during the upgrade.
- a7db71ed2787 17.0 landed
Fix the test 003_logical_slots.
- 8af917be6bad 17.0 landed
Commit b195e6d482 forgot to update meson.build.
- 8949b978ff49 17.0 landed
Use shorter file names in the upgrade logical slots test.
- b195e6d482b8 17.0 landed
Migrate logical slots to the new node during an upgrade.
- 29d0a77fa660 17.0 landed
Flush logical slots to disk during a shutdown checkpoint if required.
- e0b2eed047df 17.0 landed
Prevent possibility of panics during shutdown checkpoint.
- c6c333436491 10.0 cited