Horton

Re: Handle infinite recursion in logical replication setup

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-05-26T04:59:41Z
Lists: pgsql-hackers 
On Thu, May 26, 2022 at 2:20 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Thu, May 26, 2022 at 7:06 AM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > Here are my review comments for patch v15-0001.
> >
> > ======
> >
> > 1. Commit message
> >
> > Should this also say new test cases were added for the test_decoding plugin?
> >
> > ~~~
>
> Shall we take this out as a separate test-case patch? I think it is a
> good idea to do a missing test case for existing functionality.
>

+1. I also think this new test could be posted separately.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Improved CREATE SUBSCRIPTION message for clarity

  2. Fix the test case introduced by commit 8756930190.

  3. Raise a warning if there is a possibility of data from multiple origins.

  4. Add wait_for_subscription_sync for TAP tests.

  5. Bump catversion for commit d8cd0c6c95c0120168df93aae095df4e0682a08a.

  6. Allow users to skip logical replication of data having origin.

  7. Improve two comments related to a boolean DefElem's value

  8. doc: Fix man page whitespace issues