Horton

Thread

Commits

  1. Fix wrong word in comment.

  2. Perform logical replication actions as the table owner.

  1. Comment typo in recent push

    Peter Smith <smithpb2250@gmail.com> — 2023-04-05T00:29:09Z

    There seems to be a comment typo in the recent commit "Perform logical
replication actions as the table owner" [1].

/*
 * Switch back to the original user ID.
 *
 * If we created a new GUC nest level, also role back any changes that were
 * made within it.
 */


/role back/rollback/

~~

PSA a tiny patch to fix that.

------
[1] https://github.com/postgres/postgres/commit/1e10d49b65d6c26c61fee07999e4cd59eab2b765

Kind Regards,
Peter Smith.
Fujitsu Australia

  2. Re: Comment typo in recent push

    Robert Haas <robertmhaas@gmail.com> — 2023-04-05T12:59:12Z

    On Tue, Apr 4, 2023 at 8:29 PM Peter Smith <smithpb2250@gmail.com> wrote:
> There seems to be a comment typo in the recent commit "Perform logical
> replication actions as the table owner" [1].
>
> /*
>  * Switch back to the original user ID.
>  *
>  * If we created a new GUC nest level, also role back any changes that were
>  * made within it.
>  */
>
>
> /role back/rollback/
>
> ~~
>
> PSA a tiny patch to fix that.

Good catch, but I think it should be roll back (a verb) not rollback (a noun).

-- 
Robert Haas
EDB: http://www.enterprisedb.com

  3. Re: Comment typo in recent push

    Peter Smith <smithpb2250@gmail.com> — 2023-04-05T22:04:52Z

    Thanks for pushing.

------
Kind Regards,
Peter Smith.
Fujitsu Australia