Re: create subscription - improved warning message

On Mon, Oct 10, 2022 at 4:04 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Oct 10, 2022 at 10:10 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Amit Kapila <amit.kapila16@gmail.com> writes:
...
> The docs say [1]: "When creating a subscription, the remote host is
> not reachable or in an unclear state. In that case, the subscription
> can be created using the connect = false option. The remote host will
> then not be contacted at all. This is what pg_dump uses. The remote
> replication slot will then have to be created manually before the
> subscription can be activated."
>
> I think the below gives accurate information:
> WARNING: subscription was created, but is not connected
> HINT: You should create the slot manually, enable the subscription,
> and run %s to initiate replication.
>

+1

PSA  patch v2 worded like that.

------
Kind Regards,
Peter Smith.
Fujitsu Australia