Horton
Menu

Re: Pgoutput not capturing the generated columns

Peter Smith <smithpb2250@gmail.com>

View thread
From: Peter Smith <smithpb2250@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Michael Paquier <michael@paquier.xyz>, "Shinoda, Noriyoshi (SXD Japan FSIP)" <noriyoshi.shinoda@hpe.com>, Shubham Khanna <khannashubham1197@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "euler@eulerto.com" <euler@eulerto.com>
Date: 2025-01-22T06:20:41Z
Lists: pgsql-hackers 
On Tue, Jan 21, 2025 at 7:28 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Mon, 20 Jan 2025 at 06:14, Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > Hi Vignesh,
> >
> > Review comments for patch v53-0001:
> >
> >
> > Maybe I have some fundamental misunderstanding here, but I don't see
> > why "this approach cannot be used with psql because older version
> > servers may not have these columns". Not having the columns is the
> > whole point of using an alias approach in the first place e.g. the
> > below table t1 does not have a column called "banana" but it works
> > just fine to select an alias using that name...
>
> This is simpler than maintaining the indexes. I misunderstood your
> comment to include displaying the columns for older versions, I did
> not want to display a value for the older versions as these columns do
> not exist. I have updated the patch based on the alias approach. The
> attached patch has the changes for the same.
>

Patch v54-0001 LGTM.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Generated column replication.

  2. Rename pubgencols_type to pubgencols in pg_publication.

  3. Doc: Fix column name in pg_publication catalog.

  4. Fix buildfarm failure introduced by commit e65dbc9927.

  5. Change publication's publish_generated_columns option type to enum.

  6. Fix \dRp+ output when describing publications with a lower server version.

  7. Replicate generated columns when 'publish_generated_columns' is set.

  8. Doc: Update the behavior of generated columns in Logical Replication.

  9. Replicate generated columns when specified in the column list.

  10. Doc: Generated columns are skipped for logical replication.