Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>
To: Robert Sjöblom <robert.sjoblom@fortnox.se>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-05-17T06:27:15Z
Lists: pgsql-hackers
On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom
<robert.sjoblom@fortnox.se> wrote:
>
> Den ons 17 maj 2023 kl 03:18 skrev Peter Smith <smithpb2250@gmail.com>:
> >
> > + errhint("Use %s to disassociate the subscription from the slot after
> > disabling the subscription.",
> >
> > IMO it looked strange having the word "subscription" 2x in the same sentence.
> >
> > Maybe you can reword the errhint like:
> >
> > BEFORE
> > "Use %s to disassociate the subscription from the slot after disabling
> > the subscription."
> >
> > SUGGESTION#1
> > "Disable the subscription, then use %s to disassociate it from the slot."
> >
> > SUGGESTION#2
> > "After disabling the subscription use %s to disassociate it from the slot."
> >
> > ~~~
> >
> > BTW, it is a bit difficult to follow this thread because the subject
> > keeps changing.
> >
> > ------
> > Kind Regards,
> > Peter Smith.
> > Fujitsu Australia
>
> Good catch, I definitely agree. I'm sorry about changing the subject
> line, I'm unaccustomed to mailing lists -- I'll leave it as it is now.
>
> Attached is the revised version.
>

v4 looks good to me.

------
Kind Regards,
Peter Smith.
Fujitsu Australia



Commits

  1. Fix the errhint message and docs for drop subscription failure.

  2. doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit}

  3. Doc: mention CREATE+ATTACH PARTITION with CREATE TABLE...PARTITION OF.