Re: TOAST versus toast
Peter Smith <smithpb2250@gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-01-16T05:38:19Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
doc: TOAST not toast
- 83389838827b 19 (unreleased) landed
Attachments
- v2-0001-TOAST-not-toast.patch (application/octet-stream) patch v2-0001
On Thu, Jan 16, 2025 at 3:26 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Peter Smith <smithpb2250@gmail.com> writes: > > During some recent reviews, I came across some comments mentioning "toast" ... > > TOAST is a PostgreSQL acronym for "The Oversized-Attribute Storage > > Technique" [1]. > > It is indeed an acronym, but usages such as "toasting" are all over > our code and docs, as you see. I question whether changing that > to "TOASTing" improves readability. I agree that consistently > saying "TOAST table" not "toast table" is a good idea, but I'm > not quite convinced that removing every last lower-case occurrence > is a win, especially in these combined forms. > Hi, thanks for the reply. How about I reduce the scope by only tackling the uncontroversial stuff, and leave all those "combined forms" for another day? Attached is the reduced patch for changes to the documentation. > > - "toasted" becomes "TOASTed". > > - "toastable" becomes "TOAST-able" > > Those two choices seem inconsistent... > > > - "untoasted" becomes "un-TOASTed" > > - "detoasted" is unchanged (and so is "detoast") > > Hm, there seems a risk of confusion between "not toasted" (a > statement of fact about the contents of a Datum) versus "detoasting" > (the act of expanding a toasted datum to full form). I'd prefer > to say "not toasted" than "untoasted" because the latter feels like > it could also mean "detoasted". (And as I write this para, I'm > having a hard time wanting to upcase the words, which reinforces > my doubts about s/toast/TOAST/g.) ====== Kind Regards, Peter Smith. Fujitsu Australia