Horton

Re: Handle infinite recursion in logical replication setup

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, "Jonathan S. Katz" <jkatz@postgresql.org>
Date: 2022-08-31T06:15:29Z
Lists: pgsql-hackers 
Here are some review comments for patch v43-0002:

======

1. doc/src/sgml/ref/create_subscription.sgml

@@ -403,7 +403,9 @@ CREATE SUBSCRIPTION <replaceable
class="parameter">subscription_name</replaceabl
    warning to notify the user to check the publisher tables. Before continuing
    with other operations the user should check that publisher tables did not
    have data with different origins to prevent data inconsistency issues on the
-   subscriber.
+   subscriber. Refer to <xref linkend="replication-between-primaries"/> for
+   how <literal>copy_data</literal> and <literal>origin</literal> can be used
+   to set up replication between primaries.
   </para>

Regarding my earlier v43-0001 review (see [1] comment #2) perhaps
another pg docs section should be added in the
logical-replication.sgml (e.g. "Specifying origins during CREATE
SUBSCRIPTION"), so then this Notes text also should have more added to
it.

SUGGESTION
Refer to <XXX_REF> for details about potential initialization
inconsistency warnings using origin=NONE.
Refer to <YYY_REF> for how copy_data and origin can be used to set up
replication between primaries.

------
[1] https://www.postgresql.org/message-id/CAHut%2BPvonTd423-cWqoxh0w8Bd_Po3OToqqyxuR1iMNmxSLr_Q%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Improved CREATE SUBSCRIPTION message for clarity

  2. Fix the test case introduced by commit 8756930190.

  3. Raise a warning if there is a possibility of data from multiple origins.

  4. Add wait_for_subscription_sync for TAP tests.

  5. Bump catversion for commit d8cd0c6c95c0120168df93aae095df4e0682a08a.

  6. Allow users to skip logical replication of data having origin.

  7. Improve two comments related to a boolean DefElem's value

  8. doc: Fix man page whitespace issues