Re: Logical Replication - revisit `is_table_publication` function implementation

On Wed, Apr 8, 2026 at 4:04 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Wed, Apr 8, 2026 at 3:25 PM shveta malik <shveta.malik@gmail.com> wrote:
> >
> > On Wed, Apr 8, 2026 at 10:24 AM Peter Smith <smithpb2250@gmail.com> wrote:
> > >
> > > On Wed, Apr 8, 2026 at 1:45 PM vignesh C <vignesh21@gmail.com> wrote:
> > > >
...
> > > > And also why just check for puballtables why not to check for puballsequences
> > >
> > > I think function is_schema_publication() is unrelated to 'puballsequences'.
> > >
> > > e.g. all the following will still need to check
> > > pg_publication_namespace, regardless of the 'puballsequences' value.
> > >
> > > ex1. CREATE PUBLICATION ... FOR ALL SEQUENCES;
> > > ex2. CREATE PUBLICATION ... FOR ALL SEQUENCES, FOR TABLES IN SCHEMA s1;
> > > ex3. CREATE PUBLICATION ... FOR TABLES IN SCHEMA s1;
> > >
> >
> > IIUC, we don't support mix of ALL SEQUENCES and TABLES IN SCHEMA s1.
> > So I could not understand your point, why FOR ALL SEQ still need to
> > check pg_publication_namespace?
> >
>
> Oh! You are right.
>
> (Sorry, Vignesh, I did not recognise that combination as unsupported).
>
> I'll post a patch update to handle it.
>

PSA patch v2.

Same as before, but now also doing a quick return false from both
functions if `puballsequences` is true.

======
Kind Regards,
Peter Smith.
Fujitsu Australia