Horton

Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Robert Sjöblom <robert.sjoblom@fortnox.se>, pgsql-hackers@lists.postgresql.org
Date: 2023-06-14T03:54:46Z
Lists: pgsql-hackers 
On Wed, Jun 14, 2023 at 1:10 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, May 17, 2023 at 11:57 AM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom
> > <robert.sjoblom@fortnox.se> wrote:
> > >
> > > Attached is the revised version.
> > >
> >
> > v4 looks good to me.
> >
>
> The latest version looks good to me as well. I think we should
> backpatch this change as this is a user-facing message change in docs
> and code. What do you guys think?
>

I do not know the exact criteria for deciding to back-patch, but I am
not sure back-patching is so important for this one.

It is not a critical bug-fix, and despite being a user-facing change,
there is no functional change. Also, IIUC the previous docs existed
for 6 years without problem.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Fix the errhint message and docs for drop subscription failure.

  2. doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit}

  3. Doc: mention CREATE+ATTACH PARTITION with CREATE TABLE...PARTITION OF.