Re: Add missing period to DETAIL messages

Peter Smith <smithpb2250@gmail.com>

View thread

From: Peter Smith <smithpb2250@gmail.com>

To: Xiaopeng Wang <wxp_728@163.com>

Cc: Chao Li <li.evan.chao@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2026-04-15T07:41:10Z

Lists: pgsql-hackers

Attachments

v4-0001-DETAIL-messages-fix-capitalization-and-add-missin.patch (application/octet-stream) patch v4-0001

On Wed, Apr 15, 2026 at 3:48 PM Xiaopeng Wang <wxp_728@163.com> wrote:
>
...
>
> Looks good to me.
>
> A small comment is that, the commit message claims only “add missing period to DETAIL messages”, but apparently the patch also changes capitalization in many places, so the commit message should be updated.
>

Fair point. Thanks for your review!

PSA v4 which has an improved commit message.

======
Kind Regards,
Peter Smith.
Fujitsu Australia